Conversation
Ports diptest 0.11.0 (Hartigan's dip test for unimodality) to riscv64. scikit-build-core/CMake/pybind11 build; mirrors upstream's own wheels.yml (OpenMP enabled, arch flags disabled) and vendors a LICENSE.pcg-cpp patch since diptest's own vendoring of pcg-cpp drops the dual Apache-2.0/MIT licence texts.
luhenry
added a commit
that referenced
this pull request
Sep 8, 2026
_diptest_core has no Py_mod_gil slot, so cp314t re-enables the GIL at import and emits a RuntimeWarning; diptest's filterwarnings=error turns that into a collection error on test_diptest.py, which cascades into a KeyError on test_internal.py (gotcha 127). PYTHON_GIL=1 asks for the GIL up front instead -- same runtime behaviour, no warning -- and is ignored on the GIL builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
diptest0.11.0Compiles a single pybind11/C++ extension (
_diptest_core), implementing Hartigan's dip test for unimodality. Upstream publishes no riscv64 wheel.Mirrors upstream's
wheels.yml(OpenMP enabled, arch flags disabled).Differs from upstream
LICENSE.pcg-cppat the project root - the vendored pcg-cpp headers carry no licence file of their own.Testing
_has_openmp_supportLicense: Wheel bundles the image's libgomp (GPL-3.0, GCC Runtime Library Exception; sources published via the
gpl_sourcesjob) and pcg-cpp (Apache-2.0/MIT), whose licence text the build stages since diptest's own vendoring drops it.Patches
0001-ship-pcg-cpp-s-dual-Apache-2.0-MIT-LICENSE-in-the-wh.patch- Upstream-Status: To upstream. Without it the wheel ships pcg-cpp's compiled-in code with no licence attribution.Built locally (macOS/arm64, OpenMP on); 15 passed.